-
-
Notifications
You must be signed in to change notification settings - Fork 916
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add ability to disable annotations including canvas appearance-data #968
Open
yuliya-ivaniukovich
wants to merge
1
commit into
wojtekmaj:main
Choose a base branch
from
yuliya-ivaniukovich:#963
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wojtekmaj
reviewed
Mar 23, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Beautiful work!
Some comments I have:
annotationMode
must be documented.- Having more unit tests would be great. I'll gladly help out.
- This technically deprecates
renderForms
in favor of much more powerfulannotationMode
, so renderForms is to be marked as deprecated (this one can be on me)
be758b5
to
1a9897f
Compare
1f184c5
to
ef56712
Compare
b14700a
to
416e96c
Compare
36a36d4
to
e249af6
Compare
d14ccb7
to
744f655
Compare
2d488c1
to
a077571
Compare
1f758cc
to
ce6db03
Compare
42a8c3c
to
0d68fee
Compare
d0aabb2
to
736f3f3
Compare
How can I help to get this merged? |
About (3) deprecating renderForms: we actually need to keep both renderForms and annotationMode as they serve distinct purposes.
Example: to show filled non-editable input {
renderForms: false,
annotationMode: ENABLE_STORAGE,
} |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #963